Add explicit permissions to GitHub Actions workflows#84
Merged
Conversation
Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add explicit permissions to workflow files
Add explicit permissions to GitHub Actions workflows
Nov 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit permissions blocks to two GitHub Actions workflows that previously relied on default permissions, implementing the principle of least privilege for improved security.
- Added
permissions: contents: readto both workflow files at the workflow level - Ensures workflows only have read access to repository contents, which is all they require
- Improves security posture by explicitly defining minimal required permissions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/nodejs.yml |
Added permissions: contents: read to CI workflow that checks out code, builds, and runs tests |
.github/workflows/publish.yml |
Added permissions: contents: read to release workflow that publishes packages to npm using external token |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liuliu-dev
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow files lacked explicit
permissions:blocks, relying on default permissions instead of following least privilege principle.Changes
Added
permissions: contents: readto:.github/workflows/nodejs.yml- CI workflow that checks out code, builds, and tests.github/workflows/publish.yml- Release workflow that publishes to npmBoth workflows only need read access since they:
actions/checkout@v4secrets.npm_token(external to GitHub)Example
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.